Add missing observe internal dependency#316
Merged
TharmiganK merged 2 commits intomainfrom Jun 12, 2025
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=========================================
Coverage 87.71% 87.71%
Complexity 373 373
=========================================
Files 30 30
Lines 1188 1188
Branches 149 149
=========================================
Hits 1042 1042
Misses 92 92
Partials 54 54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
azinneera
approved these changes
Jun 12, 2025
ThisaruGuruge
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Recently the build is failing due to some compiler plugin tests and when I checked the error, it seems like the temporary distribution is missing the observe internal package which is required for compilation. This PR explicitly add that particular dependency when creating the temporary distribution.
The compiler plugin tests has imports to time and mysql packages but those are not included in the temporary distribution. IIUC since the compiler plugin tests are running without the
offlineflag these dependencies are getting resolved from central. But some how now the ballerina observe internal package is not getting resolved (IMO this is correct since this internal package resides inside the distribution and not available in the central, but I am not sure how this worked before)Attaching the complete error stack when the test fails:
Examples
N/A
Checklist
Linked to an issueUpdated the specificationUpdated the changelogAdded testsChecked native-image compatibility